Skip to content

Add ide-assist: generate_impl_trait for generate_impl #19938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2025
Merged

Add ide-assist: generate_impl_trait for generate_impl #19938

merged 3 commits into from
Jul 25, 2025

Conversation

A4-Tacks
Copy link
Contributor

@A4-Tacks A4-Tacks commented Jun 6, 2025

Adds this trait impl for a type.

trait $0Foo {
    fn foo(&self) -> i32;
}

->

trait Foo {
    fn foo(&self) -> i32;
}

impl Foo for ${1:_} {
    $0fn foo(&self) -> i32 {
        todo!()
    }
}

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2025
@A4-Tacks A4-Tacks changed the title Add generate_impl_trait for generate_impl ide-assist: Add ide-assist: generate_impl_trait for generate_impl Jun 6, 2025
@A4-Tacks A4-Tacks changed the title ide-assist: Add ide-assist: generate_impl_trait for generate_impl Add ide-assist: generate_impl_trait for generate_impl Jun 6, 2025
@A4-Tacks
Copy link
Contributor Author

r? @Veykril

ShoyuVanilla
ShoyuVanilla reviewed Jun 27, 2025
View reviewed changes
@ShoyuVanilla
Copy link
Member

Besides tabstop, other things look good

@Veykril Veykril removed their assignment Jun 27, 2025
ShoyuVanilla
ShoyuVanilla reviewed Jun 28, 2025
View reviewed changes
@A4-Tacks A4-Tacks requested a review from Veykril June 30, 2025 02:31
@A4-Tacks A4-Tacks requested a review from ShoyuVanilla July 23, 2025 02:32
ShoyuVanilla
ShoyuVanilla approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Jul 25, 2025
@ShoyuVanilla ShoyuVanilla mentioned this pull request Jul 25, 2025
Open
Merged via the queue into rust-lang:master with commit 48ccbe0 Jul 25, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2025
@ShoyuVanilla ShoyuVanilla mentioned this pull request Jul 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

@Veykril Veykril Awaiting requested review from Veykril

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@A4-Tacks @ShoyuVanilla @Veykril @rustbot